-
Notifications
You must be signed in to change notification settings - Fork 47.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dist/react-dom.js
cannot get React.__SECRET_DOM_DO_NOT_USE_OR_YOU_WILL_BE_FIRED
#7092
Comments
I think the Do you have a specific use case that you'll have to do |
That being said, I think it's true that this line https://github.com/facebook/react/blob/master/vendor/react-dom.js#L5 might be redundant. What do you think @zpao? |
@keyanzhang I just want to use minfied ReactDOMServer for server side rendering. Now, I have to use below hack.
The minified version has better performance in server side rendering. I don't why React doesn't encourage to use it. |
@mocheng You can set |
@satya164 No, it's actually not going to be the same. The minified version of React is more performant since the minification eliminates dead code and skips dynamic |
@keyanzhang IMHO if that's a concern then you should really be minifying your entire codebase to deal with all cases of it. Unless someone can show a benchmark showing a consistent measurable difference (which I doubt there is) then this seems premature, dead code would only marginally affect start-up time and I just can't see |
@syranide yeah I think minifying the entire codebase is an option. The problem of directly requiring Other than that, (surprisingly) reading process.env isn't cheap: nodejs/node#3104 (comment) |
Usually this is solved by using an option like |
@gaearon But if you're using webpack then minifying is already easily part of your process, this is really about native node.js I would say? |
I don’t know. With Webpack people often used precompiled bundles for faster build times. |
In that case, the problem here becomes solved I assume since the require in I think the recommendation here is going to be that if you are going to try to use the dist files in node, you might have a bad time. We don't recommend it. If you are trying to get performance improvements with minification and DEV checks removed, then you should precompile everything. Otherwise it's going to be a problem. There is the small issue with the UMD setup that @keyanzhang pointed out, but even if we addressed that, there are further issues that @keyanzhang brought up with components and dependencies requiring the node module. You have to rewrite to address that, at which point the problem is solved or you can easily include React itself into your build and minifiy (even if that does add some build time). |
FWIW, in the future the npm module may be a single file (or rather 2, with a single dev/prod check to split) and the whole optimization point becomes moot. (#6351 is part of that if you want to follow along) |
In version 15.1.0, npm installed react-dom has
dist/react-dom
file which imports React DOM related stuff from React. However,require('react')
doesn't have React.__SECRET_DOM_DO_NOT_USE_OR_YOU_WILL_BE_FIRED property, since react doesn't export it.As a result, we cannot use
dist/react-dom
and it is totally useless.The text was updated successfully, but these errors were encountered: