Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save CI-built node_modules as build artifacts #14205

Merged
merged 2 commits into from
Nov 13, 2018

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Nov 12, 2018

Let's save the node_modules created by the build script so that the script @acdlite is working on can publish them to NPM.

Example output here:
screen shot 2018-11-12 at 3 38 16 pm

Which extracts to:
screen shot 2018-11-12 at 4 43 14 pm

@bvaughn bvaughn force-pushed the circle-build-artifacts branch 4 times, most recently from 23a544b to 63efbec Compare November 12, 2018 23:14
@bvaughn bvaughn changed the title Save node_modules as build artifacts (WIP) Save CI-built node_modules as build artifacts Nov 13, 2018
@bvaughn bvaughn requested a review from acdlite November 13, 2018 16:22
@bvaughn bvaughn mentioned this pull request Nov 13, 2018
31 tasks
@bvaughn bvaughn merged commit 85f5a81 into facebook:master Nov 13, 2018
@bvaughn bvaughn deleted the circle-build-artifacts branch November 13, 2018 19:00
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
* Store node_modules generated by CI script as an artifact
* NPM pack artifacts before archiving
n8schloss pushed a commit to n8schloss/react that referenced this pull request Jan 31, 2019
* Store node_modules generated by CI script as an artifact
* NPM pack artifacts before archiving
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants