From 744e9b4eb4810797a93c66591fea6f9cac533b4b Mon Sep 17 00:00:00 2001 From: Jesse Beach Date: Thu, 3 Aug 2017 14:24:52 -0700 Subject: [PATCH] aria-haspop indicates popup menus. It is not needed here Summary: `aria-haspopup` is used to indicate "popup button"; buttons that, when pressed, show a little menu of options. It's not meant to indicate any element that has a dialog associated with it. In the case of draft.js, the `aria-expanded` attribute is used to indicate that the input has a dropdown with options. Reviewed By: spicyj Differential Revision: D5550366 fbshipit-source-id: 90249146a7f69f538ab2177842ee925825238ccb --- src/component/base/DraftEditor.react.js | 4 ---- src/component/base/DraftEditorProps.js | 1 - 2 files changed, 5 deletions(-) diff --git a/src/component/base/DraftEditor.react.js b/src/component/base/DraftEditor.react.js index 7d91b0e590..7b6085ba09 100644 --- a/src/component/base/DraftEditor.react.js +++ b/src/component/base/DraftEditor.react.js @@ -234,9 +234,6 @@ class DraftEditor extends React.Component { const ariaExpanded = ariaRole === 'combobox' ? !!this.props.ariaExpanded : null; - const ariaHasPopup = ariaRole === 'combobox' - ? !!this.props.ariaHasPopup - : null; return (
@@ -254,7 +251,6 @@ class DraftEditor extends React.Component { this._showPlaceholder() ? this._placeholderAccessibilityID : null } aria-expanded={readOnly ? null : ariaExpanded} - aria-haspopup={readOnly ? null : ariaHasPopup} aria-label={this.props.ariaLabel} aria-multiline={this.props.ariaMultiline} autoCapitalize={this.props.autoCapitalize} diff --git a/src/component/base/DraftEditorProps.js b/src/component/base/DraftEditorProps.js index 7ba5564329..9a724c64f0 100644 --- a/src/component/base/DraftEditorProps.js +++ b/src/component/base/DraftEditorProps.js @@ -95,7 +95,6 @@ export type DraftEditorProps = { ariaControls?: string, ariaDescribedBy?: string, ariaExpanded?: boolean, - ariaHasPopup?: boolean, ariaLabel?: string, ariaMultiline?: boolean,