Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge in games-on-k8s/docker-factorio gen_config #299

Closed
deefdragon opened this issue Dec 24, 2019 · 5 comments
Closed

Merge in games-on-k8s/docker-factorio gen_config #299

deefdragon opened this issue Dec 24, 2019 · 5 comments

Comments

@deefdragon
Copy link

games-on-k8s/docker-factorio has been effectively abandoned, but has gen_config.py, which is very powerful for the creation of the server-settings.json file. Addition of gen_config would allow for one line server launches (as opposed to starting, stoping, editing the config, and restarting), much easier kubernetes integration, and much easier public hosting of games.

License is also MIT.

I would be willing to do the merge, testing, and PR if the addition of gen_config.py is acceptable.

@SuperSandro2000
Copy link
Member

I don't really want to add python just for generating the config.

@deefdragon
Copy link
Author

deefdragon commented Dec 24, 2019

Just checked, and you do have busybox sed in the container. I would be willing to write a bash script that took a template and replaced all the values with either defaults, or the environment parameters. Only additions then would be the template and new script.

It would not take much to actually expand the script to any other configs that the user may want to edit.

@SuperSandro2000
Copy link
Member

We can also add the standalone sed cause compared to full blown python it is tiny.
I would merge it if it is error proof (eg missing variables) and maintainable.

@deefdragon
Copy link
Author

Moved to PR #304

@jonfairbanks
Copy link

This would be an awesome addition, thanks for taking this on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants