-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge in games-on-k8s/docker-factorio gen_config #299
Comments
I don't really want to add python just for generating the config. |
Just checked, and you do have busybox sed in the container. I would be willing to write a bash script that took a template and replaced all the values with either defaults, or the environment parameters. Only additions then would be the template and new script. It would not take much to actually expand the script to any other configs that the user may want to edit. |
We can also add the standalone sed cause compared to full blown python it is tiny. |
Moved to PR #304 |
This would be an awesome addition, thanks for taking this on. |
games-on-k8s/docker-factorio has been effectively abandoned, but has gen_config.py, which is very powerful for the creation of the server-settings.json file. Addition of gen_config would allow for one line server launches (as opposed to starting, stoping, editing the config, and restarting), much easier kubernetes integration, and much easier public hosting of games.
License is also MIT.
I would be willing to do the merge, testing, and PR if the addition of gen_config.py is acceptable.
The text was updated successfully, but these errors were encountered: