Fix out-of-bounds buffer access in parse_command #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the cmd buffer needs to be null terminated we need to reserve space for the null byte in the buffer. Without this change an out-of-bounds buffer access is performed if the first word is longer than 19 chars. Fixes #529
|
@nmeum Thank you for your investigation! Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the cmd buffer needs to be null terminated we need to reserve
space for the null byte in the buffer.
Without this change an out-of-bounds buffer access is performed if the
first word is longer than 19 chars.
Fixes #529