Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Quickcheck to spec to motivate dev dependency #73

Closed
DrBoolean opened this issue Jul 28, 2014 · 3 comments
Closed

Add Quickcheck to spec to motivate dev dependency #73

DrBoolean opened this issue Jul 28, 2014 · 3 comments

Comments

@DrBoolean
Copy link

Over at #68 I had an issue with using Id to express a traversable law - i.e. using an implementation within the spec.

At #66 @phadej suggested we motivate some reason to depend on the spec so we can chart it's use and have a reason for versioning.

I'd like to see a law quickcheck test script included in the spec. Something like: https://github.com/folktale/laws

That would allow people to add fantasy-land as a dev dependency as well as give me a reason to include Id

My vision is something like:

var fl = require('fantasy-land')
fl.quickcheck(MyType, [fl.functor, fl.traversable, fl.foldable]);

I also believe it makes sense to do the derivations from fl, but that might be overboard.

@phadej
Copy link
Contributor

phadej commented Jul 29, 2014

There was a PR once: #61

@SimonRichardson
Copy link
Member

I've moved the quick check lib to fantasy land. It's not as simple as what you've got in your example, but could easily be added via a wrapper!

https://github.com/fantasyland/fantasy-check

@SimonRichardson
Copy link
Member

I'm going to close this, as we do have a checking library for it now. You can suggest helper methods (see @DrBoolean idea above) in that library now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants