fix: include directoryPrefix when using autoPrefix #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
requested changes
Dec 28, 2023
| @@ -69,7 +69,7 @@ app.ready(function (err) { | |||
| }) | |||
|
|
|||
| app.inject({ | |||
| url: '/semiautomatic/items' | |||
| url: '/manualprefix/semiautomatic/items' | |||
There was a problem hiding this comment.
Is this change necessary due to the change in the fixture, or is this a breaking change?
Can you please not alter existing tests?
There was a problem hiding this comment.
Oh, sorry. Yes it is breaking change.
The behaviour between dirNameRoutePrefix and autoPrefix was not properly defined in the docs before this change.
There was a problem hiding this comment.
If the intended behaviour in the changed test is to override directoryPrefix, but keep options.prefix, I think a new exported option plugin.directoryOverride would be better.
There was a problem hiding this comment.
Let's avoid a breaking change, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm encountering this issue myself, so might as well fix it.
Fixes #205
Checklist
npm run testandnpm run benchmarkand the Code of conduct