-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge next
into master
#396
Conversation
* upgrade for next realease refactor: push 'unit' script at the end fix: update ci explicitkly add and remove typescript lugin test: dont explicitly add ts plugin test: dont explicitly add ts plugin * create specific test for unit test test/typescript/*.ts * fix: nullish needed for non Node.js runtime * fix: reverse version * fix: increase timeout * refactor: use node instead of tap for typescript scripts * fix: force deletion of @tapjs/typescript * chore: update test * chore: update command * chore: check plugin of tap * fixup * chore: fix commands --------- Co-authored-by: jean <[email protected]>
* upgrade for next realease refactor: push 'unit' script at the end fix: update ci explicitkly add and remove typescript lugin test: dont explicitly add ts plugin test: dont explicitly add ts plugin * create specific test for unit test test/typescript/*.ts * fix: nullish needed for non Node.js runtime * fix: reverse version * fix: increase timeout * refactor: use node instead of tap for typescript scripts * fix: force deletion of @tapjs/typescript * chore: update test * chore: update command * chore: check plugin of tap * fixup * chore: fix commands --------- Co-authored-by: jean <[email protected]>
No idea what is wrong with these tests, and I have no time or inclination to figure out Jest. |
As far as I remember, it didn't always fail, but we should fix this. FYI, I'm very busy with an onboarding for the next 2 weeks and have tons of things todo/learn. |
It is the problem I faced for local environment. |
Could this have been introduced by recent additions? https://github.com/fastify/fastify-autoload/commits/next/ |
It never run successfully in my local environment. |
* test: fix jest * test: remove mixed async and callback
await new Promise(function (resolve) { | ||
const child = exec(`${instance} ${process.cwd()}/test/typescript-jest/integration/instance.ts`); | ||
await new Promise(function (resolve, reject) { | ||
const child = exec(`${instance} "${process.cwd()}/test/typescript-jest/integration/instance.ts"`); |
Check warning
Code scanning / CodeQL
Shell command built from environment values Medium test
absolute path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
As titled.