Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): add funding and contribs #422

Merged
merged 1 commit into from
Dec 1, 2024
Merged

chore(package): add funding and contribs #422

merged 1 commit into from
Dec 1, 2024

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Dec 1, 2024

Checklist

@Fdawgs Fdawgs merged commit 57f09b3 into master Dec 1, 2024
7 of 13 checks passed
@Fdawgs Fdawgs deleted the Fdawgs-patch-1 branch December 1, 2024 19:09
@@ -38,11 +38,28 @@
"auto"
],
"author": "Matteo Collina <[email protected]>",
"contributors": [
{
"name": "Frazer Smith",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I think all or nothing here

Copy link
Member Author

@Fdawgs Fdawgs Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a bit of a pain to go through every repo and get all the contributors so I was hoping everyone would add themselves.

Unless you're suggesting I just copy the contributors value from the main Fastify repo?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a bit of a pain to go through every repo and get all the contributors so was hoping everyone would add themselves.

let's keep valid this one, but I would like to check in the npm page what is happning.

Right now, without the contributors array, the output shows the npm org team:

image

Not sure if now it will be overwritten

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't be overwritten, the collaborator list on the npm page is users who have publish privileges. If you look at the main Fastify package it only shows 4 collaborators even when the collaborators list in the package.json has 20 people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants