Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move from tap to node:test #306

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Conversation

eugleenyc
Copy link
Contributor

These changes are related to the issue fastify/fastify#5555
Changed signer.test.js and cookie.test.js to use node:test instead of tap.

Checklist

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dancastillo dancastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use test context so assert.strictEqual -> t.assert.strictEqual

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add back in t.plan. The test will end before assertions are compelete i believe
Then for the tests with callbacks update to

test('test name here', (t, done) => {
  // set up and test code
  done() // call after last assertion
})

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address @dancastillo's concern.

@Uzlopak
Copy link
Contributor

Uzlopak commented Dec 8, 2024

@jsumners
@dancastillo

Fixed the tests... PTAL.

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gurgunday gurgunday merged commit 38913b7 into fastify:master Dec 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants