-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move from tap to node:test #306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use test context so assert.strictEqual
-> t.assert.strictEqual
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add back in t.plan
. The test will end before assertions are compelete i believe
Then for the tests with callbacks update to
test('test name here', (t, done) => {
// set up and test code
done() // call after last assertion
})
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address @dancastillo's concern.
Signed-off-by: Aras Abbasi <[email protected]>
Fixed the tests... PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
These changes are related to the issue fastify/fastify#5555
Changed signer.test.js and cookie.test.js to use node:test instead of tap.
Checklist
npm run test
and the Code of conduct