Clean-out service_id from manifest when deleting a service. #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to be based off of #266 and thus makes it hard to review. Is this intentional? |
|
@phamann This was intentional. I purposely didn't ping you for a PR review as I was waiting for the other PR to be merged (thus cleaning up the extra changes in this PR). To be fair I should probably have made this a 'Draft PR' instead. |
Integralist
force-pushed
the
integralist/clean-sid-manifest
branch
from
72d4606
to
13c1b0a
Compare
Integralist
force-pushed
the
integralist/clean-sid-manifest
branch
from
13c1b0a
to
e719ebb
Compare
kailan
reviewed
May 11, 2021
kailan
requested changes
May 11, 2021
Integralist
force-pushed
the
integralist/clean-sid-manifest
branch
from
e719ebb
to
4870555
Compare
Integralist
force-pushed
the
integralist/clean-sid-manifest
branch
from
4870555
to
a311bc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When you delete a service, the
service_idin the manifest persists. Which (depending on what subcommands you execute next) could cause an unexpected error.Solution: When deleting a service, be sure to clean-out the Service ID value from the manifest.