Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework state-saving #27

Open
rjbs opened this issue Dec 27, 2016 · 0 comments
Open

rework state-saving #27

rjbs opened this issue Dec 27, 2016 · 0 comments

Comments

@rjbs
Copy link
Member

rjbs commented Dec 27, 2016

From #26:

So we actually want send_reminder to do the removal of the item, but that means that check-reminders might run twice and find the same reminder in the queue, not yet removed by send_reminder, which is still waiting. So we probably want the yield to send_reminder-then-save-state to mark the job as taken in such a way that it won't be saved to state, but will prevent second-enqueueing of the send-reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant