-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Zendesk when Linear issue changes #175
base: main
Are you sure you want to change the base?
Conversation
@alh I took a first stab at the linear zendesk integration. I stole most of the code from LinearNotification.pm to get the http_app up and running and then just replaced the webhook response with my own stuff. I am not completely sure I understand how http_app is set up/ how it works/ how to test the webhook (I know how it works in theory), so if you have some time to zoom or something at some point I would appreciate it! |
This mostly seems right, but probably what we want to do instead is having the one synergy webhook listener (LinearNotification.pm) and then multiple/different actions can happen in there when processing the webhook As to testing, yeah we can talk in slack / zoom, up to you! |
When a support blocker linear issue is updated with a new comment, an internal comment is posted on its associated zendesk ticket and the ticket status is changed to "Open".
Its functionality was moved to LinearNotification.pm
@wolfsage moved the functionality into LinearNotification. I will hit you up on slack for a convo on testing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how this ever worked. I don't think "issue comments" is a valid type. Have you tested this all?
return Future->done; | ||
})->retain; | ||
|
||
$self->zendesk->ticket_api->update_by_zendesk_id_f($1, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if these two updates can possibly compete/block each other? It might be worth it to chain the status change to open once the add_comment_to_ticket finishes
b140047
to
945aca5
Compare
15d3cd9
to
3a95bf4
Compare
f23a1b1
to
4022b0d
Compare
5697dff
to
32f29ba
Compare
aafd26b
to
eee1d40
Compare
When a support blocker linear issue is updated with a new comment, an
internal comment is posted on its associated zendesk ticket and the
ticket status is changed to "open".