Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Zendesk when Linear issue changes #175

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RashaMou
Copy link
Contributor

When a support blocker linear issue is updated with a new comment, an
internal comment is posted on its associated zendesk ticket and the
ticket status is changed to "open".

@RashaMou
Copy link
Contributor Author

@alh I took a first stab at the linear zendesk integration. I stole most of the code from LinearNotification.pm to get the http_app up and running and then just replaced the webhook response with my own stuff.

I am not completely sure I understand how http_app is set up/ how it works/ how to test the webhook (I know how it works in theory), so if you have some time to zoom or something at some point I would appreciate it!

@wolfsage
Copy link
Contributor

This mostly seems right, but probably what we want to do instead is having the one synergy webhook listener (LinearNotification.pm) and then multiple/different actions can happen in there when processing the webhook

As to testing, yeah we can talk in slack / zoom, up to you!

When a support blocker linear issue is updated with a new comment, an
internal comment is posted on its associated zendesk ticket and the
ticket status is changed to "Open".
Its functionality was moved to LinearNotification.pm
@RashaMou
Copy link
Contributor Author

RashaMou commented Feb 4, 2022

@wolfsage moved the functionality into LinearNotification. I will hit you up on slack for a convo on testing!

@RashaMou RashaMou requested a review from wolfsage February 4, 2022 16:48
Copy link
Contributor

@wolfsage wolfsage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how this ever worked. I don't think "issue comments" is a valid type. Have you tested this all?

lib/Synergy/Reactor/LinearNotification.pm Show resolved Hide resolved
return Future->done;
})->retain;

$self->zendesk->ticket_api->update_by_zendesk_id_f($1, {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if these two updates can possibly compete/block each other? It might be worth it to chain the status change to open once the add_comment_to_ticket finishes

@rjbs rjbs force-pushed the main branch 2 times, most recently from b140047 to 945aca5 Compare October 28, 2022 17:19
@rjbs rjbs force-pushed the main branch 6 times, most recently from 15d3cd9 to 3a95bf4 Compare March 10, 2023 18:29
@rjbs rjbs force-pushed the main branch 4 times, most recently from f23a1b1 to 4022b0d Compare October 26, 2023 00:12
@rjbs rjbs force-pushed the main branch 8 times, most recently from 5697dff to 32f29ba Compare February 6, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants