Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide consistent version of pyyaml no matter how you install faucet #3139

Closed
gizmoguy opened this issue Aug 6, 2019 · 1 comment · Fixed by #3165
Closed

Provide consistent version of pyyaml no matter how you install faucet #3139

gizmoguy opened this issue Aug 6, 2019 · 1 comment · Fixed by #3165

Comments

@gizmoguy
Copy link
Member

gizmoguy commented Aug 6, 2019

Faucet installed via pip and docker will always get the latest version of pyyaml (5.1.2 at time of writing).

Faucet installed via apt will get whatever the system version of pyyaml is (this could be quite old). Recently pyyaml in the 5.x branch have changed the behaviour of parsing colons which affects IPv6 addresses in faucet configuration.

I think we should modify requirements.txt to add an exact version match for pyyaml (pyyaml==5.1.2) and then ship our own debian packages for pyyaml so that faucet users get a consistent configuration experience no matter how they decide to install faucet.

@gizmoguy
Copy link
Member Author

pyyaml 5.1 breaks a few things: yaml/pyyaml#265

I'm now thinking we should force ourselves to 3.13 pending pyyaml 5.2 which will fix a few things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant