Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XidMap internal registerSubTree must match ignore constraints of NodeManager.registerSubTree #8

Open
pedro93 opened this issue May 20, 2016 · 0 comments
Open

XidMap internal registerSubTree must match ignore constraints of NodeManager.registerSubTree #8

pedro93 opened this issue May 20, 2016 · 0 comments

Comments

@pedro93
Copy link

pedro93 commented May 20, 2016

Given the following file:

<html>
<body>

    <!-- This is a comment -->
    <!-- <p>This is a paragraph. No content should be displayed</p> -->
    <!-- Comments are not displayed in the browser -->

</body>
</html>

The program will crash with the following error:

XID_map.cpp:256 getXIDbyNode() :Node(Impl) not found

This is because the traversal and registering of xids in https://github.com/fdintino/xydiff/blob/master/src/XID_map.cpp#L351 does not match https://github.com/fdintino/xydiff/blob/master/src/Diff_NodesManager.cpp#L225, the comment nodes are ignored in the second traversal but not the first hence there is a mismatch in the nodes that are processed. The solution to this would be to have consistent processing of nodes in both methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pedro93