-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch returns Model instance by default #146
Comments
I have looked a bit more into feathers-sequelize tests and see that it uses feathers-service-tests which has a tests for this stuff. Since the tests are passing it suggests that patch is working as expected. However the behaviour in my own app and the code suggests otherwise. So I will be following up to determine whats happening here and perhaps write some extra tests to see what is going on. |
Does that mean we shouldn't publish #147? It looks fine to me. |
Closed via #147 and released as v2.2.1 Thank you for the pull request and looking forward to a separate PR for the tests! |
Patch does not default to raw.
https://github.com/feathersjs/feathers-sequelize/blob/master/src/index.js#L153
The result is that a newly created service with default settings has all the methods providing json in the after hooks except for patch.
The text was updated successfully, but these errors were encountered: