Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Add support for generating version range dependencies #94

Open
ignatenkobrain opened this issue Jul 31, 2017 · 4 comments
Open

RFE: Add support for generating version range dependencies #94

ignatenkobrain opened this issue Jul 31, 2017 · 4 comments

Comments

@ignatenkobrain
Copy link

Currently gem2rpm generates multiple lines if one dependency required which leads to problems.

RPM 4.14 (since F27) will get ability to specify things like BuildRequires: (rubygem(foo) >= 5.1 with rubygem(foo) < 5.3), or even more complicated cases would work as well: BuildRequires: ((rubygem(foo) >= 5.1 with rubygem(foo) < 5.3) or (rubygem(foo_ext) >= 5.1 with rubygem(foo_ext) < 5.3))

@voxik
Copy link
Member

voxik commented Jul 31, 2017

Several things:

  1. The generated BR are commented out by default and used more or less just as scaffold for packager.
  2. Versioned BR are generally discouraged [1].
  3. Is the "with" operator actually approved? Is it mentioned in guidelines? Support of RPM is one thing and guidelines are another thing (you remember tilde in versions, right?)

@ignatenkobrain
Copy link
Author

Versioned BR are generally discouraged [1].

Thanks for pointer, I will make sure that it is updated when we will get with richop approved.

Is the "with" operator actually approved? Is it mentioned in guidelines? Support of RPM is one thing and guidelines are another thing (you remember tilde in versions, right?)

No, it's not yet implemented in RPM, but will be very soon. It's not mentioned in guidelines, but https://fedoraproject.org/wiki/Changes/Packaging_Rust_applications_and_libraries explicitly mention this and this change has been already approved by FESCo. And supporting with is only way how we will get rust packaging in Fedora.


At this point I'm waiting for final version of with richop support. Once it is there, I will submit Rust packaging guidelines + some other wiki pages for FPC approval.

@ignatenkobrain
Copy link
Author

P.S. I created this bug just for feature to be implemented, doesn't have to be turned on by default. So once FPC approves it, we could just flip the switch on.

@ignatenkobrain
Copy link
Author

@voxik btw, this functionality already available in F27+ RPM/DNF/etc., so you can already try it locally. I'm still trying to get rel-eng support for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants