Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(mocktail): update README.md to include any(that: ...) #226

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

rocboronat
Copy link
Contributor

Status

READY

Breaking Changes

NO

Description

Last week I messed a lot trying to validate a method that received a parameter type outside my control was called. As that type didn't have equals overridden, mocktail never detected that the parameter was passed. So I had to use another strategy to check if that parameter was passed: to specify which attributes of the type to check.

I'm adding that strategy here as an example to help others. It's actually not mocktail documentation, but mocktail can also use that strategy, so it will save lives.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@rocboronat rocboronat requested a review from felangel as a code owner January 15, 2024 08:52
@felangel felangel added the documentation Improvements or additions to documentation label Jan 19, 2024
@felangel felangel changed the title Add an example to the README with "any that is a" docs(mocktail): update README.md to include any(that: ...) example Jan 19, 2024
@felangel felangel changed the title docs(mocktail): update README.md to include any(that: ...) example docs(mocktail): update README.md to include any(that: ...) Jan 19, 2024
Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution! ✅

@felangel felangel merged commit 5d4573a into felangel:main Jan 19, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants