From c66c99c292b9af68b6debc5ee8367aa37b4acbf4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felipe=20Corr=C3=AAa=20da=20Silva=20Sanches?= Date: Thu, 26 Oct 2017 17:41:46 -0200 Subject: [PATCH] emit only a WARNing for bad fonts on test/163 (issue #1621) --- Lib/fontbakery/specifications/googlefonts.py | 2 +- Lib/fontbakery/specifications/googlefonts_test.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Lib/fontbakery/specifications/googlefonts.py b/Lib/fontbakery/specifications/googlefonts.py index 93a9f62be0..b88060b930 100644 --- a/Lib/fontbakery/specifications/googlefonts.py +++ b/Lib/fontbakery/specifications/googlefonts.py @@ -4680,7 +4680,7 @@ def com_google_fonts_test_163(ttFont): platformID=plat): if len(familyname_str + stylename_str) > 20: failed = True - yield FAIL, ("The combined length of family and style" + yield WARN, ("The combined length of family and style" " exceeds 20 chars in the following '{}' entries:" " FONT_FAMILY_NAME = '{}' / SUBFAMILY_NAME = '{}'" "").format(PLATID_STR[plat], diff --git a/Lib/fontbakery/specifications/googlefonts_test.py b/Lib/fontbakery/specifications/googlefonts_test.py index 51c2e2d83f..0772af4355 100644 --- a/Lib/fontbakery/specifications/googlefonts_test.py +++ b/Lib/fontbakery/specifications/googlefonts_test.py @@ -2187,7 +2187,7 @@ def test_id_163(): status, message = list(test(ttFont))[-1] assert status == PASS - # Then we FAIL with the long family/style names + # Then we emit a WARNing with the long family/style names # that were used as an example on the glyphs tutorial # (at https://glyphsapp.com/tutorials/multiple-masters-part-3-setting-up-instances): for index, name in enumerate(ttFont["name"].names): @@ -2200,9 +2200,9 @@ def test_id_163(): ttFont["name"].names[index].string = "WithAVeryLongStyleName".encode(name.getEncoding()) break - print ("Test FAIL with a bad font...") + print ("Test WARN with a bad font...") status, message = list(test(ttFont))[-1] - assert status == FAIL + assert status == WARN def test_id_164():