Capabilities: Allow string user_ids

[akirk]

In the friends plugin I create virtual users that have a string as their user id, thus the type hint causes a fatal:

<b>Fatal error</b>:  Uncaught TypeError: Felix_Arntz\AI_Services_Dependencies\Felix_Arntz\WP_OOP_Plugin_Lib\Capabilities\Capability_Filters::filter_map_meta_cap(): Argument #3 ($user_id) must be of type int, string given, called in wp/wp-includes/class-wp-hook.php on line 324 and defined in wp/wp-content/plugins/ai-services/third-party/Capabilities/Capability_Filters.php:147
Stack trace:
#0 wp/wp-includes/class-wp-hook.php(324): Felix_Arntz\AI_Services_Dependencies\Felix_Arntz\WP_OOP_Plugin_Lib\Capabilities\Capability_Filters-&gt;filter_map_meta_cap(Array, 'friend', 'friends-virtual...', Array)
#1 wp/wp-includes/plugin.php(205): WP_Hook-&gt;apply_filters(Array, Array)
#2 wp/wp-includes/capabilities.php(876): apply_filters('map_meta_cap', Array, 'friend', 'friends-virtual...', Array)
#3 wp/wp-includes/class-wp-user.php(782): map_meta_cap('friend', 'friends-virtual...')
#4 wp/wp-content/plugins/friends/includes/class-user.php(1140): WP_User-&gt;has_cap('friend')

Can we allow strings here, too?

[LeTraceurSnork]

Since WordPress itself implies that user ID is integer (PHPDoc says it's integer, default value is 0), I guess it's safe to say that while technically (since the property is not strictly typed) it is possible to set the ID as string, it shall not be done and therefore must trigger _doing_it_wrong() function

[felixarntz]

@akirk I agree with @LeTraceurSnork, user IDs in WordPress are expected to be integers, per the documentation, so it's against that documentation to use another type.

[akirk]

I guess it makes sense. Probably I need to resort to using fake numeric ids then.