Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset Button Implementation #2

Closed
fennifith opened this issue Jan 21, 2017 · 2 comments
Closed

Reset Button Implementation #2

fennifith opened this issue Jan 21, 2017 · 2 comments
Labels

Comments

@fennifith
Copy link
Owner

When the reset button disappears, the height of the layout it's inside becomes 0 because the reset button was the only visible view inside it. Since android:animateLayoutChanges only affects views inside the layout, the width of the button is animated but not the height. This makes the transition seem a bit jumpy.

Not too urgent to fix as the dialog is still usable in this state, however it would look a lot nicer if this didn't happen.

@fennifith fennifith added the bug label Jan 21, 2017
@fennifith
Copy link
Owner Author

The reset button is going to be absent from 0.1.0. Helps simplify things a little. I'll add it back later.

@fennifith fennifith changed the title Buggy Animation With Reset Button (No Image Picker) Reset Button Implementation Nov 8, 2018
@fennifith
Copy link
Owner Author

I'm not adding this back. It's kind of useless, and I can't come up with a situation where you would actually want this over a button separate from the dialog with the same purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant