Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why does this crate not use the cid crate? #74

Open
matthiasbeyer opened this issue Apr 3, 2021 · 2 comments
Open

Why does this crate not use the cid crate? #74

matthiasbeyer opened this issue Apr 3, 2021 · 2 comments
Labels
enhancement good first issue

Comments

@matthiasbeyer
Copy link

Hi, maybe I am misunderstanding something, so I am not sure whether there's an obvious reason why not, ... so why doesn't this crate use the cid crate for the content ids and instead uses String in its API?
@ferristseng
Copy link
Owner

Definitely seems like something we could add

@matthiasbeyer
Copy link
Author

Well, how to transform a AddResponse (for example) into a Cid then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matthiasbeyer @ferristseng