Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you target "Text" layers as "children"? #30

Closed
l-campbell opened this issue Apr 23, 2024 · 7 comments
Closed

Can you target "Text" layers as "children"? #30

l-campbell opened this issue Apr 23, 2024 · 7 comments
Labels
on roadmap This request is in the Code Connect roadmap

Comments

@l-campbell
Copy link

Question

I have a Figma component that uses a "Text" layer instead of a property. With code connect, is there a way to target this layer to map to a coded component prop? In my scenario, I'm trying to map this to the label prop in the coded component. I've tried using figma. children() with the name of the layer with no success, I know this isn't the intended here.

Context

Layers

All the nested layers in this tree are either row or column layouts.

Screenshot 2024-04-23 at 04 31 19

Render

Screenshot 2024-04-23 at 04 32 11

Info

Screenshot 2024-04-23 at 04 32 21

Code connect

Screenshot 2024-04-23 at 04 38 05
@tomduncalf-figma
Copy link
Contributor

Hi @l-campbell, right now we don't support this I'm afraid, but it's on our roadmap as we know some design system do use overrides like this instead of props. I'll keep this issue open so we can update you on progress.

@tomduncalf-figma tomduncalf-figma added the on roadmap This request is in the Code Connect roadmap label Apr 23, 2024
@l-campbell
Copy link
Author

Thanks @tomduncalf-figma!

@mryechkin
Copy link

Just chiming in here to say that our design team also uses a similar approach in some components, so it's great to hear it will be supported 🎉

@alisonjoseph
Copy link

alisonjoseph commented May 10, 2024

+1 for needing this functionality
Screenshot 2024-05-24 at 8 42 49 AM

@alisonjoseph
Copy link

Confirmed this works for my above example with Tabs. 🙌

However I'm struggling to get the value for an example that has the text layer nested more deeply. Any solution for this without updating the actual Figma component itself?
Screenshot 2024-06-18 at 1 36 22 PM

@tomduncalf-figma
Copy link
Contributor

Hey @alisonjoseph, happy to hear it's working for you. You should be able to reference this nested layer using figma.nestedProps, something like:

nested: figma.nestedProps("_Number input base", {
  text: figma.textContent("Text")
})

which would then be available as props.nested.text

@alisonjoseph
Copy link

@tomduncalf-figma Nested property support is 🔥 worked perfectly, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on roadmap This request is in the Code Connect roadmap
Projects
None yet
Development

No branches or pull requests

5 participants