Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actor events for the Verified Registry, Miner and Market Actors [Meta Issue] #1464

Closed
1 of 2 tasks
aarshkshah1992 opened this issue Oct 25, 2023 · 6 comments · Fixed by #1491
Closed
1 of 2 tasks

Actor events for the Verified Registry, Miner and Market Actors [Meta Issue] #1464

aarshkshah1992 opened this issue Oct 25, 2023 · 6 comments · Fixed by #1491
Assignees

Comments

@aarshkshah1992
Copy link
Contributor

aarshkshah1992 commented Oct 25, 2023

@anorth
Copy link
Member

anorth commented Oct 25, 2023

Thanks. I reckon we want to include the built-in market here too. Scope could expand further (e.g. to Datacap) but verifreg/miner/market covers the core deal-making actions

@aarshkshah1992 aarshkshah1992 changed the title Actor events for the Verified Registry and Miner Actor [Meta Issue] Actor events for the Verified Registr, Miner and Market Actors [Meta Issue] Oct 26, 2023
@aarshkshah1992 aarshkshah1992 changed the title Actor events for the Verified Registr, Miner and Market Actors [Meta Issue] Actor events for the Verified Registry, Miner and Market Actors [Meta Issue] Oct 26, 2023
@aarshkshah1992
Copy link
Contributor Author

@anorth Updated the issue to account for the Market Actor.

@anorth
Copy link
Member

anorth commented Oct 26, 2023

Thanks. This can be all one FIP, doesn't need to be separated for different actors.

@anorth
Copy link
Member

anorth commented Oct 26, 2023

For the market, I think a minimal set we can use is deal-published, deal-activated, deal-completed, deal-terminated. A deal finishes with one or the other of those last two.

We could potentially add deal-expired (before activation) but it would only ever happen in cron, so probably not worth it here.

In master, deal completion is also only in cron, but that will be changed with FIP-0074

@aarshkshah1992
Copy link
Contributor Author

aarshkshah1992 commented Nov 7, 2023

Next steps here are to address feedback on the FIP and come up with gas cost estimations for event emission.

@aarshkshah1992
Copy link
Contributor Author

Raised #1491 to implement this in a DDO world.

@rjan90 rjan90 moved this from In Progress to In Review in nv22 - Track Board Jan 29, 2024
@rjan90 rjan90 moved this from In Review to Done in nv22 - Track Board Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants