-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actor events for the Verified Registry, Miner and Market Actors [Meta Issue] #1464
Comments
Thanks. I reckon we want to include the built-in market here too. Scope could expand further (e.g. to Datacap) but verifreg/miner/market covers the core deal-making actions |
@anorth Updated the issue to account for the Market Actor. |
Thanks. This can be all one FIP, doesn't need to be separated for different actors. |
For the market, I think a minimal set we can use is deal-published, deal-activated, deal-completed, deal-terminated. A deal finishes with one or the other of those last two. We could potentially add deal-expired (before activation) but it would only ever happen in cron, so probably not worth it here. In master, deal completion is also only in cron, but that will be changed with FIP-0074 |
Next steps here are to address feedback on the FIP and come up with gas cost estimations for event emission. |
Raised #1491 to implement this in a DDO world. |
This issue aims to keep track of the remaining work needed to land this workstream.
TODO
Rebase and merge Built-in Actor events for DDO #1491 to master after FIP-0076: Merge integration/direct-onboarding into master #1486 AND FIP-0074 Merge integration/manual-settlement into master #1483 lands on master
Ensure the following two updates to FIP-0083 are approved and merged:
- Update to add gas costs for emitting events to FIP 0083 FIPs#925
- Update FIP-0083 based on feedback from review of implementation FIPs#913
The text was updated successfully, but these errors were encountered: