Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return event but don't fail when encountering data of unknown encoding #228

Open
willscott opened this issue Aug 2, 2021 · 1 comment
Open

Comments

@willscott
Copy link

There may be cases where the sending side of a data transfer encounters a block of data encoded with a codec that is not known to it.
Currently, as it attempts to make the ipld.Node representation and parse such a block, it will end up with an error, which will populate up to the overall data transfer.
Instead, the raw contents of the block should still be able to be transferred un-parsed, but a channel even should be transmitted to indicate to the receiver that the node could not be parsed, and recursion into a potential dag below that item was not attempted.
The receiver can then handle that as it wishes - potentially parsing the block locally and initiating additional transfers for links it discovers.

@willscott
Copy link
Author

related / part of filecoin-project/go-fil-markets#365

This was referenced Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant