Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Transfer -- Unified Storage Validator #237

Closed
hannahhoward opened this issue May 9, 2020 · 0 comments · Fixed by #247
Closed

Data Transfer -- Unified Storage Validator #237

hannahhoward opened this issue May 9, 2020 · 0 comments · Fixed by #247
Assignees

Comments

@hannahhoward
Copy link
Collaborator

hannahhoward commented May 9, 2020

Currently, we have two seperate validators for data transfer vouchers in storage market:

  1. ClientRequestValidator
  2. ProviderRequestValidator

The Client only accepts pulls while the Provider only accepts pushes. However, in GFC, we can only have one data transfer instance. So, we need to have a single RequestValidator that can be configured to operate like a Client or a Provider or both.

I would recommend something like:

type RequestValidator struct {
   acceptPushes bool
   acceptPulls bool
   deals *statestore.StateStore
}

Then in lotus we'll make two, one that accepts pushes & the other that accepts pulls
In GFC, we'll make only one that accepts both.

@hannahhoward hannahhoward changed the title Data Transfer -- Unified Voucher Data Transfer -- Unified Storage Validator May 9, 2020
@dirkmc dirkmc mentioned this issue Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants