Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Market Data API for direct data onboarding #11173

Closed
10 tasks
snissn opened this issue Aug 15, 2023 · 5 comments
Closed
10 tasks

Market Data API for direct data onboarding #11173

snissn opened this issue Aug 15, 2023 · 5 comments
Assignees

Comments

@snissn
Copy link
Contributor

snissn commented Aug 15, 2023

User Story

People want visibility into how data and deals are being stored on filecoin. We want an API to provide information about direct fil+ deals.

Direct FIL+ is a label for changes to the Filecoin built-in actors, and the components that interact with them, to enable gas-cheap data onboarding, including Filecoin Plus. The built-in storage market actor is bypassed, and the verified registry’s on-chain allocation/claim record suffices to represent a simple “deal”. Direct data onboarding can’t handle client payments (yet), but most deals today have no on-chain payment anyway.

After the initial Direct FIL+ changes, subsequent, smaller changes will be possible to support scalable FIL+ allocations (single transaction covering multiple sectors) and flexibility for other kinds of data applications.

for more see direct data onboarding notion doc https://www.notion.so/pl-strflt/Direct-FIL-impacts-work-outline-57399e0fdfd242d09aabad7357945798

Acceptance Criteria

Deliverables

Preview Give feedback

Technical Breakdown

Development

Preview Give feedback

Testing

Preview Give feedback
@snissn snissn self-assigned this Aug 15, 2023
@jennijuju jennijuju added this to the Direct Data Onboarding milestone Aug 17, 2023
@jennijuju jennijuju removed this from the Direct Data Onboarding milestone Aug 17, 2023
@jennijuju
Copy link
Member

the market address could be null too.

might worth showing if the data has associated datacap as well?

@jennijuju
Copy link
Member

Should we show data availability time too? i.e: when its stated to be stored , and till when? (i assume that would could just be the sector lifetime?

@anorth
Copy link
Member

anorth commented Aug 22, 2023

There are three pieces of data that will become independent, but are currently coupled.

  • A data piece and its commitment into a sector
  • A verified claim for a piece (that grants a power multiplier)
  • A deal with the built-in market actor (that might involve payments)

A data piece might be accompanied by none, either, or both the other two.

In the future, there will also be

  • A "deal" with any other user-programmed actor that functions as a market

...though Lotus shouldn't be expected to interpret state of user-programmed actors, merely provide generic access to it.

a new api that can get all of the data pieces information from all of the sectors either the data is onboarded via f05 or not.

As written, this deliverable must be rooted in the raw piece information, though you should think carefully whether this is the right deliverable to ask for.

Piece commitments will not generally be available in chain state, only in the message history. Thus to provide this information, Lotus needs to index the piece commitments as they appear in the new ProveCommit2/ProveReplicaUpdate3 messages to be developed. For sectors that are onboarded via the legacy methods, the piece commitments are present in the corresponding built-in market deal state (until those deals expire, which is independent of the sector expiration).

Given a piece CID/size, Lotus could then index both the market deal state and verified registry claims by piece+sector in order to associate that related information, if it exists.

It's worth noting that a more restricted deliverable would be much easier to support. If scope were limited to insight into only verified pieces, or only deals, then indexing message history would be unnecessary, and the relevant information would all be available in chain state.

@jennijuju
Copy link
Member

jennijuju commented Sep 6, 2023

okay.. the more I think about this the more I believe lotus is not the right place to provide a piece <> sector indexing, I would imagine this to be something covered along with the other data dumps lily has https://lilium.sh/data/dumps/

Spec-Ed out in Filecoin data piece <> sector indexers/dumps here

@rjan90
Copy link
Contributor

rjan90 commented Feb 12, 2024

Superceeded by #11614

@rjan90 rjan90 closed this as completed Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

4 participants