Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data transfer restart for the miner #4380

Closed
hannahhoward opened this issue Oct 14, 2020 · 2 comments
Closed

Add data transfer restart for the miner #4380

hannahhoward opened this issue Oct 14, 2020 · 2 comments
Assignees
@aarshkshah1992
Labels
area/data-transfer area/markets/provider dif/easy An existing lotus user should be able to pick this up effort/hours Effort: Hours kind/enhancement Kind: Enhancement P2 P2: Should be resolved

Comments

@hannahhoward
Copy link
Contributor

Similar to code in https://github.com/filecoin-project/lotus/pull/4363/files,

It would be nice to have a command for lotus-miner that restarted datatransfers from the provider side.

Just needs:

  • a MarketRestartDataTransfer on the api_storage api
  • an implementation (should be almost identical to ClientRestartDataTransfer)
  • a cli command - can model off the command for lotus client restart-transfer but should probably be called lotus-miner data-transfers restart to maintain naming consistency.
@hannahhoward hannahhoward added area/markets Area: Markets dif/easy An existing lotus user should be able to pick this up effort/hours Effort: Hours kind/enhancement Kind: Enhancement P2 P2: Should be resolved labels Oct 14, 2020
@aarshkshah1992 aarshkshah1992 mentioned this issue Oct 14, 2020
Closed
@jennijuju jennijuju added this to the 💹Storage Deal Success milestone Feb 11, 2021
@jennijuju
Copy link
Member

resolved by #5553

@dirkmc
Copy link
Contributor

dirkmc commented Feb 11, 2021

I think this was actually fixed by #4387

@dirkmc dirkmc closed this as completed Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aarshkshah1992 aarshkshah1992

Labels
area/data-transfer area/markets/provider dif/easy An existing lotus user should be able to pick this up effort/hours Effort: Hours kind/enhancement Kind: Enhancement P2 P2: Should be resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Miner Data Transfer Restart Cmd filecoin-project/lotus
4 participants
@dirkmc @hannahhoward @aarshkshah1992 @jennijuju