Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallet market withdraw should use FundManager.Withdraw() #5100

Closed
dirkmc opened this issue Dec 2, 2020 · 1 comment · Fixed by #5112
Closed

wallet market withdraw should use FundManager.Withdraw() #5100

dirkmc opened this issue Dec 2, 2020 · 1 comment · Fixed by #5112

Comments

@dirkmc
Copy link
Contributor

dirkmc commented Dec 2, 2020

wallet market withdraw currently attempts to withdraw funds from the storage market actor regardless of how much is reserved by ongoing deals.

It should instead use FundManager.Withdraw() so as to not withdraw an amount that would cause deals to run into funding issues.

Probably it make sense to add a WalletWithdraw(ctx, from, addr, amt) API endpoint, implemented in https://github.com/filecoin-project/lotus/blob/master/node/impl/full/wallet.go
@hannahhoward
Copy link
Contributor

Thumbs up on my end.

@ingar ingar mentioned this issue Dec 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use FundManager to withdraw funds, add MarketWithdraw API filecoin-project/lotus
2 participants
@dirkmc @hannahhoward