Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip out empty spaces around contract bytes #9803

Closed
jennijuju opened this issue Dec 6, 2022 · 1 comment
Closed

Strip out empty spaces around contract bytes #9803

jennijuju opened this issue Dec 6, 2022 · 1 comment
Labels
area/ux Area: UX dif/easy An existing lotus user should be able to pick this up good first issue Good for newcomers P3 P3: Might get resolved

Comments

@jennijuju
Copy link
Member

for lotus chain create-evm-actor --hex

when there is unintentional newlines/empty spaces in the byte code, one will run into

ERROR: failed to decode contract: encoding/hex: invalid byte: U+000

for user's sake, we should stripe it out before compilation
@jennijuju jennijuju added P2 P2: Should be resolved area/ux Area: UX good first issue Good for newcomers dif/easy An existing lotus user should be able to pick this up labels Dec 6, 2022
@jennijuju jennijuju moved this to 📋 Backlog in Network v18 Dec 6, 2022
@jennijuju jennijuju moved this from 📋 Nice To Haves to 🌟 In Scope in Network v18 Dec 7, 2022
@Stebalien Stebalien changed the title Stripe put empty spaces for the contract bytes Strip out empty spaces around contract bytes Dec 8, 2022
@rickiey rickiey mentioned this issue Dec 15, 2022
Closed
@jennijuju jennijuju added P3 P3: Might get resolved and removed P2 P2: Should be resolved labels Dec 16, 2022
@jennijuju jennijuju linked a pull request Dec 19, 2022 that will close this issue
fix:Strip out empty spaces and prefix around contract bytes #9879
Closed
@jennijuju jennijuju moved this from 🌟 In Scope to 🏗 In progress in Network v18 Dec 21, 2022
@rickiey rickiey mentioned this issue Dec 26, 2022
Closed
@jennijuju jennijuju moved this from 🏗 In progress to 👀 In review in Network v18 Jan 6, 2023
@magik6k magik6k mentioned this issue Feb 9, 2023
Merged
7 tasks
@magik6k
Copy link
Contributor

magik6k commented Feb 9, 2023

#10224

@magik6k magik6k closed this as completed Feb 9, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Network v18 Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ux Area: UX dif/easy An existing lotus user should be able to pick this up good first issue Good for newcomers P3 P3: Might get resolved
Projects
No open projects
Network v18
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix:Strip out empty spaces and prefix around contract bytes
2 participants
@magik6k @jennijuju