Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:chain:splitstore auto prune #9123

Merged
merged 2 commits into from
Aug 8, 2022
Merged

feat:chain:splitstore auto prune #9123

merged 2 commits into from
Aug 8, 2022

Conversation

ZenGround0
Copy link
Contributor

@ZenGround0 ZenGround0 commented Aug 4, 2022

Related Issues

Proposed Changes

Auto prune of coldstore

  1. Add logic to trigger chain prune on head events
  2. Add config options to support this

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@ZenGround0 ZenGround0 changed the base branch from master to feat/chain-prune-reborn August 4, 2022 04:56
@ZenGround0 ZenGround0 marked this pull request as ready for review August 5, 2022 04:16
@ZenGround0 ZenGround0 requested a review from a team as a code owner August 5, 2022 04:16
@ZenGround0 ZenGround0 requested review from magik6k and arajasek August 5, 2022 04:34
blockstore/splitstore/splitstore.go Show resolved Hide resolved
blockstore/splitstore/splitstore_compact.go Outdated Show resolved Hide resolved
blockstore/splitstore/splitstore_compact.go Outdated Show resolved Hide resolved
@ZenGround0 ZenGround0 force-pushed the feat/chain-prune-reborn branch from aed3aea to 231135b Compare August 5, 2022 19:35
@ZenGround0 ZenGround0 force-pushed the feat/chain-prune-reborn branch from 71343b9 to 94a348f Compare August 5, 2022 20:15
Base automatically changed from feat/chain-prune-reborn to master August 5, 2022 20:34
post rebase fix

make gen

fix auto prune opts
@@ -81,6 +82,8 @@ func (s *SplitStore) HeadChange(_, apply []*types.TipSet) error {
curTs := apply[len(apply)-1]
epoch := curTs.Height()

log.Warnf("Head epoch %d", epoch)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably don't want this log

@ZenGround0 ZenGround0 merged commit 8b7be6d into master Aug 8, 2022
@ZenGround0 ZenGround0 deleted the feat/auto-prune branch August 8, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants