Skip to content
This repository has been archived by the owner on Nov 26, 2020. It is now read-only.

[test request] deals stress test #18

Open
raulk opened this issue Jun 16, 2020 · 6 comments
Open

[test request] deals stress test #18

raulk opened this issue Jun 16, 2020 · 6 comments
Assignees
Labels
discomfort-factor/8 Discomfort factor: I touched my eyes after picking up a Jalapeño (10,000 SHU). kind/test-scenario Kind: Test Scenario status/blocked Status: Blocked topic/deals Topic: Deals workstream/e2e-tests Workstream: End-to-end Tests

Comments

@raulk
Copy link
Member

raulk commented Jun 16, 2020

What would you like us to test?

Stress testing for % of deals that go through in adverse conditions (e.g. nodes suddenly going offline, etc).

Technical implementation details.

Also generate a baseline that captures how the system behaves normal/ideal conditions.

What should we measure?

  1. Test several deals one client to multiple miners. (1 client => N miners)
  2. Test several deals many clients to one miner. (N clients => 1 miner).
  3. "Make a deal, wipe the provider blockstore, verify unsealing works — I’m not sure this has truly been tested."
  • @raulk: this is more of a data lifecycle test. In other terms: clear the miner cache so that when queried for the data, it has to fall back to unsealing the sector (recovering it from archive/cold storage).

On a scale from 0-10, what's the proposed discomfort factor? In other words, how uncomfortable would you be if we went live without having tested this? Explain why.

TBD.

Additional remarks.

Requestor: @hannahhoward.

@raulk raulk added hint/needs-analysis Hint: Needs Analysis hint/needs-triage Hint: Needs Triage kind/test-scenario Kind: Test Scenario labels Jun 16, 2020
@raulk raulk self-assigned this Jun 16, 2020
@Robmat05 Robmat05 assigned vyzo and unassigned raulk Jun 16, 2020
@raulk raulk added this to the Sprint 2 milestone Jun 24, 2020
@raulk raulk modified the milestones: Sprint 2, Sprint 3 Jun 26, 2020
@raulk
Copy link
Member Author

raulk commented Jun 30, 2020

@nonsense @vyzo I edited the description to add the details provided by Hannah.

@vyzo
Copy link
Contributor

vyzo commented Jul 3, 2020

A couple of observations from running with 300 deals, both serial and concurrent with 2 miners and 3 clients.
In the serial case, after an overnight run, one client succeeded, but the other two got terminally stuck in a StorageDealSealing state.
In the concurrent case, almost all deals get stuck in the StorageDealSealing state.

@raulk
Copy link
Member Author

raulk commented Jul 3, 2020

@vyzo thanks for the input! We need to make this actionable so that we can investigate further. It may as well be an issue on our end. Possibly related to the fact that we're in catch-up mining mode and miners may be building separate chains. Could you please upload the logs from both runs?

@vyzo
Copy link
Contributor

vyzo commented Jul 3, 2020

So digging further in the concurrent stress test logs, the miners just stopped at block 155; no errors.

@raulk raulk modified the milestones: Sprint 3, Sprint 4 Jul 7, 2020
@raulk raulk added topic/deals Topic: Deals hint/needs-scoring Hint: Needs Scoring and removed hint/needs-analysis Hint: Needs Analysis hint/needs-triage Hint: Needs Triage labels Jul 8, 2020
@whyrusleeping whyrusleeping added discomfort-factor/8 Discomfort factor: I touched my eyes after picking up a Jalapeño (10,000 SHU). and removed hint/needs-scoring Hint: Needs Scoring labels Jul 8, 2020
@raulk
Copy link
Member Author

raulk commented Jul 9, 2020

We have reported the issues we found upstream: filecoin-project/lotus#2294.

@raulk raulk added the status/blocked Status: Blocked label Jul 9, 2020
@raulk raulk removed this from the Sprint 4 milestone Jul 13, 2020
@raulk raulk added this to the Sprint 5 milestone Jul 13, 2020
@raulk raulk added the workstream/e2e-tests Workstream: End-to-end Tests label Jul 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
discomfort-factor/8 Discomfort factor: I touched my eyes after picking up a Jalapeño (10,000 SHU). kind/test-scenario Kind: Test Scenario status/blocked Status: Blocked topic/deals Topic: Deals workstream/e2e-tests Workstream: End-to-end Tests
Projects
None yet
Development

No branches or pull requests

4 participants