Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth_getLogs - Block range filters do not work #1285

Closed
jaeaster opened this issue Dec 15, 2022 · 2 comments
Closed

eth_getLogs - Block range filters do not work #1285

jaeaster opened this issue Dec 15, 2022 · 2 comments

Comments

@jaeaster
Copy link

I'm seeing behavior where I can query for an event and find it
if fromBlock == targetBlock == toBlock,
but not when fromBlock < targetBlock < toBlock

e.g.

await provider.getLogs({
  address: "0xa3743970690B21043c5d14A0c9418DC7bAF33A3d",
  fromBlock: 15638,
  toBlock: 15639,
  topics: []
})
=> []

await provider.getLogs({
  address: "0xa3743970690B21043c5d14A0c9418DC7bAF33A3d",
  fromBlock: 15639,
  toBlock: 15639,
  topics: []
})
=> (3) [{}, {}, {}]
@iand
Copy link

iand commented Dec 15, 2022

This might already have been fixed by filecoin-project/lotus#9815 which was merged into feat/nv18-events on 8 Dec. What version are you testing against?

@jaeaster
Copy link
Author

Ahh ok great, looks like it's already fixed.

I'm testing against Wallaby so it's the Sapphire + patches release (on my phone so can't easily grab the direct link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants