Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp supplied to FVM around null rounds is wrong / needs clarification #1632

Closed
arajasek opened this issue Feb 2, 2023 · 1 comment
Closed
Assignees
Labels
P1 P1: Must be resolved

Comments

@arajasek
Copy link
Contributor

arajasek commented Feb 2, 2023

As currently implemented in the reference implementation, the FVM is created with a "timestamp" always corresponding to the non-null round being executed. However, this gets tricky around null rounds, which still have execution (cron) that needs to occur. We need to:

  • clarify what the correct behaviour is (see here)
  • Fixup clients if necessary (likely necessary).

Note that this doesn't actually have any consequences right now, because none of the Cron operations query the timestamp, but we should align and fixup.

@raulk
Copy link
Member

raulk commented Feb 10, 2023

Fix merged in filecoin-project/lotus#10189.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 P1: Must be resolved
Projects
None yet
Development

No branches or pull requests

3 participants