fix(schema): remove blocking processing indexes and improve processing stats table #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g stats table The processing indexes are very slow to create against populated databases. Remove them and add them back in as part of a later conversion of the processing tables to hypertables (see #111) While we are amending this migration, also change the structure of the visor_processing_stats table. Fixes #120
|
This should unblock releasing features that are held off pending this index migration. |
willscott
reviewed
Oct 21, 2020
| @@ -126,7 +128,7 @@ func (r *ProcessingStatsRefresher) Run(ctx context.Context) error { | |||
| } | |||
|
|
|||
| func (r *ProcessingStatsRefresher) collectStats(ctx context.Context) (bool, error) { | |||
| subQueries := []string{statsActors} | |||
| subQueries := []string{fmt.Sprintf(statsActors, actorCodeCase)} | |||
There was a problem hiding this comment.
does this mean we're templating the case statement into each of the sub-select's in the union?
is there a way to select that into a place that can then be directly used in each of the union'd selects directly?
There was a problem hiding this comment.
I could try something clever like inserting into a temporary table and joining against it, but I'm not sure it's worth it. The case is evaluated once per actor code per subquery (since we have already grouped by code). Perhaps about 120 times which I think is quite low compared to the cost of grouping over 30 million rows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The processing indexes are very slow to create against populated databases. Remove them
and add them back in as part of a later conversion of the processing tables to
hypertables (see #111)
While we are amending this migration, also change the structure of the visor_processing_stats
table. Fixes #120