Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Avoid ingesting binary and unused data #241

Merged
merged 3 commits into from
Nov 19, 2020
Merged

chore: Avoid ingesting binary and unused data #241

merged 3 commits into from
Nov 19, 2020

Conversation

frrist
Copy link
Member

@frrist frrist commented Nov 18, 2020

close #204

@frrist frrist requested review from placer14 and willscott November 18, 2020 02:17
@frrist frrist self-assigned this Nov 18, 2020
@frrist frrist force-pushed the frrist/fix-204 branch 2 times, most recently from b420024 to 2cea402 Compare November 18, 2020 02:31
iand
iand reviewed Nov 18, 2020
View reviewed changes
Copy link
Contributor

@iand iand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want to drop drand_block_entries? I thought that mapped blocks to the drand round number, which seems useful to keep. #204 doesn't mention deleting it.

@frrist
Copy link
Member Author

frrist commented Nov 18, 2020

Thanks @iand I missed that in my read of the issue. I have reverted the removal of the drand_block_entries.

@frrist
chore: remove ingestion for binary and unused data
411f7cd 
- Remove the following tables:
  - public.drand_entries
- Remove the Following columns:
  - public.block_headers ticket
  - public.block_headers election_proof
  - public.messages params
  - public.receipts return

closes #204
@iand iand self-requested a review November 19, 2020 13:47
@placer14
Merge remote-tracking branch 'origin/master' into frrist/fix-204
2a18e12 
* origin/master:
  fix: Remove hack to RestartOnFailure
  fix: Reorder migrations after merging latest master (#248)
  feat: add repo-read-only flag to enable read or write on lotus repo (#250)
  chore: Update CHANGELOG
  chore: Incl migration in CI test
  fix: Make ChainVis into basic views
  failure to get lock when ExitOnFailure is true now exits
  chore: remove redundant branch image push
  dont use branch name when tag is set
  remove negation
  use git tag in docker image
  Adds an option to exit on failure. (#202)
@placer14
fix: Reorder migration to merge to master
0cf9ff3
@placer14
Copy link
Contributor

Does 0cf9ff3 look okay to you, @frrist ?

@frrist
Copy link
Member Author

frrist commented Nov 19, 2020

Yup looks fine assuming it works when ran.

@placer14
Copy link
Contributor

It does! CI proves the migrations now: https://app.circleci.com/pipelines/github/filecoin-project/sentinel-visor/834/workflows/2326c51e-554c-4ea8-97b2-317c25811bd9/jobs/1816/parallel-runs/0/steps/0-109

@placer14 placer14 merged commit d588dea into master Nov 19, 2020
@placer14 placer14 deleted the frrist/fix-204 branch November 19, 2020 23:44
@placer14 placer14 mentioned this pull request Nov 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willscott willscott willscott approved these changes

@placer14 placer14 placer14 approved these changes

@iand iand iand approved these changes

Assignees

@frrist frrist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid ingesting binary, unused data
4 participants
@frrist @placer14 @iand @willscott