fix: optimisable height functions #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is idempotent and is already applied to the monitoring and analysis dbs |
|
Just, facinating.
|
alanshaw
approved these changes
Nov 26, 2020
iand
approved these changes
Nov 27, 2020
iand
force-pushed
the
olizilla/height-fun-fast
branch
from
520538c to
4248e0a
Compare
add attributes to the height functions to allow postgres to optimise them - IMMUTABLE - the function cannot modify the database and always returns the same result when given the same argument value - RETURNS NULL ON NULL INPUT - the function is not executed when there are null arguments; instead a null result is assumed automatically. - PARALLEL SAFE - safe to run in parallel mode without restriction. with these in place my test query execution time goes down from 3m40s to 12s, which is as fast as the inlined, funtionless version License: MIT Signed-off-by: Oli Evans <[email protected]>
iand
force-pushed
the
olizilla/height-fun-fast
branch
from
4248e0a to
902759d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add attributes to the height functions to allow postgres to optimise them
with these in place my test query execution time goes down from 3m40s to 12s, which is as fast as the inlined, functionless version.
see: https://www.postgresql.org/docs/12/sql-createfunction.html
License: MIT
Signed-off-by: Oli Evans [email protected]