Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: replace local state diffing with StateChangeActors API method #303

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

iand
Copy link
Contributor

@iand iand commented Dec 8, 2020

As per the recent analysis of API usage this change saves us over 9000 roundtrips to lotus with a corresponding performance gain.

@iand iand self-assigned this Dec 8, 2020
@iand iand added the kind/enhancement Improvement to an existing feature label Dec 8, 2020
@iand iand force-pushed the iand/actor-state-api branch from 4fbdeee to 06714be Compare December 8, 2020 12:00
@codecov-io
Copy link

Codecov Report

Merging #303 (06714be) into master (a1118f0) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #303   +/-   ##
======================================
  Coverage    44.9%   44.9%           
======================================
  Files          20      20           
  Lines        1978    1978           
======================================
  Hits          890     890           
  Misses        969     969           
  Partials      119     119           

@iand iand requested a review from frrist December 10, 2020 10:29
@iand iand merged commit f56b151 into master Dec 11, 2020
@iand iand deleted the iand/actor-state-api branch December 11, 2020 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants