Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: respect log level flag and allow per logger levels #34

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

iand
Copy link
Contributor

@iand iand commented Sep 23, 2020

Removes hard coded log levels so the log-level flag now properly controls the default log level.

Adds a log-level-named flag which takes a comma delimited list of logger:level pairs that specify the log levels for specific loggers. Can also be set via the VISOR_LOG_LEVEL_NAMED environment variable.

Fixes #32

Removes hard coded log levels so the log-level flag now properly controls the
default log level.

Adds a log-level-named flag which takes a comma delimited list of logger:level pairs
that specify the log levels for specific loggers. Can also be set via the
VISOR_LOG_LEVEL_NAMED environment variable.

Fixes #32
@iand iand requested review from frrist and placer14 September 23, 2020 10:32
Copy link
Contributor

@placer14 placer14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate allowing the rpc logger to still be overridden. LGTM

@iand iand merged commit f0dc231 into master Sep 25, 2020
@iand iand deleted the iand/respect-loglevel branch September 25, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log-level flag ignored
2 participants