Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add VISOR_TEST_DB environment variable to specify test database #35

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

iand
Copy link
Contributor

@iand iand commented Sep 23, 2020

Helps avoid accidental wiping of data in local database.

@iand iand requested review from frrist and placer14 September 23, 2020 14:49
Copy link
Contributor

@placer14 placer14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

if err != nil {
return nil, xerrors.Errorf("parse database URL: %w", err)
}
opt.PoolSize = poolSize
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@iand iand merged commit 7f8acce into master Sep 25, 2020
@iand iand deleted the iand/test-safety branch September 25, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants