chore: increase lens object cache size #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #377 +/- ##
======================================
Coverage 43.1% 43.1%
======================================
Files 25 25
Lines 1932 1932
======================================
Hits 833 833
Misses 972 972
Partials 127 127 |
placer14
approved these changes
Feb 8, 2021
frrist
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics show that we are continually fetching ~20k blocks per tipset which suggests that the LRU cache used is too small. Increasing it to 500k made a big difference in performance as shown in grafana screenshot below. This change bumps the LRU to 50k to balance memory consumption with performance.
Top-right: note number of requests being made to API drop off dramatically with a larger LRU
Mid-right: note processing times are lower
Bottom-left: memory consumption is up, but not greatly so
The spikes appear to be unrelated and are not present once visor has been running for a while.