Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Push docker images on all *-master branch updates #49

Merged
merged 3 commits into from
Sep 30, 2020
Merged

chore: Push docker images on all *-master branch updates #49

merged 3 commits into from
Sep 30, 2020

Conversation

placer14
Copy link
Contributor

No description provided.

@placer14 placer14 requested a review from ognots September 30, 2020 15:32
@ognots
Copy link
Contributor

ognots commented Sep 30, 2020

you also have to adjust scripts/push-docker-tags.sh
see https://github.com/filecoin-project/sentinel-drone/blob/master/scripts/push-docker-tags.sh

@placer14
Copy link
Contributor Author

Unfortunate that chore/docker-push-on-all-master matches the new filter and attempted to push. It failed due to the slash in the branch name. We could further restrict the pattern to match only a single word before -master.

@placer14 placer14 merged commit f278ec7 into master Sep 30, 2020
@placer14 placer14 deleted the chore/docker-push-on-all-master branch September 30, 2020 16:30
placer14 added a commit that referenced this pull request Sep 30, 2020
@placer14
Merge remote-tracking branch 'origin/master' into butterfly-master
56d9b83 
* origin/master:
  chore: Push docker images on [a-z]*-master branch updates (#49)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ognots ognots ognots approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@placer14 @ognots