Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use clock package for time mocking #65

Merged
merged 2 commits into from
Oct 7, 2020
Merged

chore: use clock package for time mocking #65

merged 2 commits into from
Oct 7, 2020

Conversation

iand
Copy link
Contributor

@iand iand commented Oct 6, 2020 •
edited
Loading

As suggested by @lanzafame

@iand iand requested review from placer14 and lanzafame October 6, 2020 09:48
placer14
placer14 approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@placer14 placer14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@placer14
Merge remote-tracking branch 'origin/master' into iand/clock
2ea19ea 
* origin/master:
  fix: fix failing chain head indexer tests (#66)
  chore: remove unused redis-based scheduler code (#64)
@placer14
Copy link
Contributor

placer14 commented Oct 6, 2020

Pushed merge conflicts up. Will wait for happy CI and then merge.

@iand iand merged commit e8990fb into master Oct 7, 2020
@iand iand deleted the iand/clock branch October 7, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frrist frrist frrist approved these changes

@placer14 placer14 placer14 approved these changes

@lanzafame lanzafame Awaiting requested review from lanzafame

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iand @placer14 @frrist