Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(model): replace BeginContext with RunInTransaction #7

Merged
merged 2 commits into from
Sep 17, 2020

Conversation

frrist
Copy link
Member

@frrist frrist commented Sep 16, 2020

Correctly handles commit and rollback cases for errors that we not handled before. Thank you for the prompt to use this pattern @iand!

@frrist frrist requested a review from iand September 16, 2020 19:50
@frrist frrist self-assigned this Sep 16, 2020
@frrist frrist force-pushed the frrist/run-in-transaction branch from 9233bce to ea4b128 Compare September 16, 2020 19:51
- correctly handles commit and rollback cases for errors
services/indexer/types.go Outdated Show resolved Hide resolved
@iand iand merged commit e731d3c into master Sep 17, 2020
@iand iand deleted the frrist/run-in-transaction branch September 17, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants