feat(task): Create chainvis views and refresher #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iand
approved these changes
Oct 8, 2020
| return wait.RepeatUntil(ctx, r.refreshRate, r.refreshView) | ||
| } | ||
|
|
||
| func (r *ChainVisRefresher) refreshView(ctx context.Context) (bool, error) { |
There was a problem hiding this comment.
Minor nit: would be cleaner to have these views in a slice that is looped over
placer14
force-pushed
the
feat/chainvis-view
branch
from
4f5cf98 to
c8c9a42
Compare
placer14
force-pushed
the
feat/chainvis-view
branch
from
c8c9a42 to
9009eea
Compare
placer14
force-pushed
the
feat/chainvis-view
branch
from
9009eea to
c4b2f54
Compare
placer14
added a commit
that referenced
this pull request
Oct 14, 2020
* origin/master: fix: remove errgrp from UnindexedBlockData persist fix: verify there are no missing migrations before migrating (#89) chore: add tests for reward and power actor state extracters (#83) feat: support v2 actor codes (#84) feat(debug): Process actor by head without persistance (#86) fix: use debugf logging method in message processor (#82) feat(task): Create chainvis views and refresher (#77) perf: minor optimization of market actor diffing (#78) chore: fail database tests if VISOR_TEST_DB not set (#79) test(storage): add test to check for duplicate schema migrations (#80) in-process lotus "repo" lens (#75) Conflicts: tasks/actorstate/miner.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR serves two purposes:
--chainvis-refresh-rate=1mwith some value greater than 0 (which disables the refresh loop entirely).Overall, this pattern intends to add zero operational overhead and minimal developer overhead (specifically in maintaining the underlying tables supporting these views). Refresh is completely optional. Creation of materialized views without data initialized are virtually free to maintain in schema. Cost of refreshing views is managed by configurable refresh rate.
Potential areas of improvement: