-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lotusrepo lens #90
lotusrepo lens #90
Conversation
"github.com/filecoin-project/specs-actors/actors/util/adt" | ||
"github.com/ipfs/go-cid" | ||
blockstore "github.com/ipfs/go-ipfs-blockstore" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong blockstore:
https://godoc.org/github.com/filecoin-project/lotus/lib/blockstore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the definition an alias type though, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't dig hat you pulled: you might have just grabbed aliases and it is fine. But for future-self...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* origin/master: feat: Add historical indexer metrics (#92) fix(lens): Include dependencies needed for Repo Lens (#90) Move migration to schema version 10 fix(migrations): migrations require version 0 feat: add message gas economy processing perf(db): reduce batch size for chain history indexer (#105) fix: use hash index type for visor_processing_actors_code_idx (#106) feat: set application name in postgres connection (#104) feat: add visor processing stats table (#96) feat(task): add chain economics processing (#94) get actor name for both versions of specs-actors (#101)
…-view * origin/master: feat: Add miner_sector_posts tracking of window posts (#74) feat: Add historical indexer metrics (#92) fix(lens): Include dependencies needed for Repo Lens (#90) Move migration to schema version 10 fix(migrations): migrations require version 0 feat: add message gas economy processing perf(db): reduce batch size for chain history indexer (#105) fix: use hash index type for visor_processing_actors_code_idx (#106) feat: set application name in postgres connection (#104) feat: add visor processing stats table (#96) feat(task): add chain economics processing (#94) get actor name for both versions of specs-actors (#101) fix: remove errgrp from UnindexedBlockData persist
This change switches the repo lens to directly create a chainstore, rather than spinning up a full internal lotus node. This (per @ribasushi) should be lighter weight.
Need to audit usage of the lens to see if other modules than the chain one are used and need to also be filled in.
fix #88