Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miner actor SectorCommitments map should be a lookup #2536

Closed
ZenGround0 opened this issue Apr 10, 2019 · 2 comments
Closed

Miner actor SectorCommitments map should be a lookup #2536

ZenGround0 opened this issue Apr 10, 2019 · 2 comments

Comments

@ZenGround0
Copy link
Contributor

Description

All other map datastructures within actor state are implemented as hamt-based lookups. From conversation with @acruikshank it looks like the SectorCommitments implementation was meant to be moved to a lookup but it slipped through the cracks.

Acceptance criteria

We have evaluated whether this is the right thing to do.

We have changed the implementation of the SectorCommitments map to use a lookup.

Risks + pitfalls

cc @laser in case this issue is missing key context suggesting we not use a lookup to implement this map.

This change can't be introduced live into a new network without a model for change protocol upgrade (protocol breaking)

Where to begin

Understand actor lookups and modify miner.go

@anorth
Copy link
Member

anorth commented Jun 4, 2019

@ZenGround0 FYI this issue might be either redundant or repurposed into your SectorSet(/Map) work

@anorth anorth added A-storage and removed A-chain labels Jun 4, 2019
@anorth
Copy link
Member

anorth commented Jul 14, 2019

I think this is the same as #2888

@anorth anorth closed this as completed Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants