Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SectorSet: AMT design spike #2887

Closed
ZenGround0 opened this issue Jun 4, 2019 · 2 comments
Closed

SectorSet: AMT design spike #2887

ZenGround0 opened this issue Jun 4, 2019 · 2 comments
Assignees

Comments

@ZenGround0
Copy link
Contributor

Description

We need to solidify the design of the A[rray]M[apped]T[rie] structure proposed as the implementation for sector sets

We should write this as a subpackage of actor. This issue is done when we have a plan for all of the software changes needed to make this AMT in software and spec it out in prose.

Acceptance criteria

Build a prototype AMT to implement SectorSets. Likely file several issues after this spike for writing/factoring into something more robust. Don't forget to track work for writing up the spec for this.

Risks + pitfalls

Don't rush in without understanding what's going on BUT
Don't spend too much time reading about it before trying to build it

Where to begin

Read through the design doc to get the background and relevant links.

go-hamt-ipld spec and code, the Bagwell HAMT paper and the sectorset spec issue (links in doc) are all going to be useful.

@ZenGround0
Copy link
Contributor Author

This currently exists in this spec PR. It is low priority for me to get this spec PR through to completion but I'd like to get to it within a few weeks. Word on the street is that @whyrusleeping plus some others might be leading the implementation charge on this one.

@anorth
Copy link
Member

anorth commented Jul 10, 2019

@ZenGround0 I think we can close this now. The AMT still needs to be implemented, but that's a different issue, and the work may happen outside go-filecoin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants