DO NOT MERGE: POC using json-schema-to-typescript library #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeighFinegold
changed the title
LeighFinegold
changed the title
LeighFinegold
force-pushed
the
model-gen
branch
from
5856707 to
a4b9cdf
Compare
LeighFinegold
commented
Dec 24, 2024
| @@ -0,0 +1,162 @@ | |||
| export type Metadata = { | |||
There was a problem hiding this comment.
These file souldn't be checked in, but doing so for folks to review and see output
LeighFinegold
commented
Dec 24, 2024
| @@ -0,0 +1,6 @@ | |||
| /** | |||
There was a problem hiding this comment.
The library seems to have a bug whereby just defs alone in a file will not generate any definitions. It will generate definitions via a schema which is why core.d.ts has flow definition generated.
LeighFinegold
commented
Dec 24, 2024
| export type Metadata = { | ||
| [k: string]: unknown; | ||
| }[]; | ||
| export type Metadata1 = { |
There was a problem hiding this comment.
Should MetaData be a general concept which is leveraged by flow.json and core.json to prevent this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the early proof-of-concept (PoC) work with model generation #701
Lessons learned will be attached to issue rather than PR.