-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to remove the X-Powered-By header when using onRequest() #754
Comments
I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight. |
@SDrinkwater I think this issue should be raised in https://github.com/GoogleCloudPlatform/functions-framework-nodejs, which is the underlying framework used by cloud functions. |
Anyone any ideas how long till the fix in functions-framework-nodejs will be released? |
Hi all, I'm going to close this issue since it is unfortunately out of the control of the maintainers of this repo. Separately, I've reached out to the maintainers of functions-framework-nodejs to see if there will be a release anytime soon. If I hear back, I will update here. Otherwise, if you are facing this issue, your best bet is to ask about the next release on that repo. |
For those of you who are still waiting on a fix, I would recommend you just manually change the
|
Related issues
[REQUIRED] Version info
node: 10.20.1
firebase-functions: 3.9.0
firebase-tools: 8.4.2
firebase-admin: 9.0.0
[REQUIRED] Test case
Deploy the following function, or run it locally with the firebase emulator:
[REQUIRED] Steps to reproduce
Run the following command in your terminal (update the url to match the project - this example is using the base emulator url):
Notice that the
x-powered-by
header comes back populated withExpress
.[REQUIRED] Expected behavior
I would expect to have full control over which headers are returned with the response when using
https.onRequest()
. Regardless of which approach I use, this header always gets populated.I have tried the following approaches:
[REQUIRED] Actual behavior
The
x-powered-by
header always gets populated withExpress
.Were you able to successfully deploy your functions?
Yes, everything deploys successfully with no errors.
The text was updated successfully, but these errors were encountered: